Skip to content

Comments

Update images to latest and fix boskos#1720

Merged
knative-prow-robot merged 2 commits intoknative:masterfrom
chizhg:FixBoskos
Feb 18, 2020
Merged

Update images to latest and fix boskos#1720
knative-prow-robot merged 2 commits intoknative:masterfrom
chizhg:FixBoskos

Conversation

@chizhg
Copy link
Contributor

@chizhg chizhg commented Feb 18, 2020 •
edited
Loading

What this PR does, why we need it:

  1. Make the same change as Add Boskos CRDs to prow/cluster, and bump Boskos back to latest kubernetes/test-infra#16267 to fix the boskos breaking change
  2. Revert the revert for Update prow to v20200212-1f7b8ac1d #1716 to update the images
  3. Boskos has another bug fix in boskos: disable controller-runtime manager metrics kubernetes/test-infra#16270, and the image updated by the prow-auto-bumper was before this fix, so bump boskos to v20200217-8ab6e0b2c to pick it up

I have tested on the staging-prow cluster and everything works.

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 18, 2020
@knative-prow-robot
Copy link
Collaborator

knative-prow-robot commented Feb 18, 2020

@chizhg: GitHub didn't allow me to request PR reviews from the following users: chizhg.

Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

What this PR does, why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes to reviewers:

User-visible changes in this PR:

/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 18, 2020
@knative-prow-robot
Copy link
Collaborator

knative-prow-robot commented Feb 18, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chizhg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2020
@chizhg chizhg changed the title [WIP]update images to latest and fix boskos Update images to latest and fix boskos Feb 18, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 18, 2020
@chizhg chizhg requested a review from chaodaiG February 18, 2020 22:08
@chaodaiG
Copy link
Contributor

chaodaiG commented Feb 18, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2020
@knative-prow-robot knative-prow-robot merged commit fb304f6 into knative:master Feb 18, 2020
@chizhg chizhg deleted the FixBoskos branch February 18, 2020 23:27
@chizhg chizhg mentioned this pull request Feb 19, 2020
Closed
@chizhg chizhg mentioned this pull request Sep 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

Assignees

@chaodaiG chaodaiG

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chizhg @knative-prow-robot @chaodaiG